[Differential] [Request, 79 lines] D1140: Keep contexts alive when referenced by a problem.

mwolff (Milian Wolff) noreply at phabricator.kde.org
Sun Mar 13 22:27:54 UTC 2016


mwolff created this revision.
mwolff added a reviewer: KDevelop.
Herald added a subscriber: kdevelop-devel.

REVISION SUMMARY
  This fixes the signature assistant when invoked from the header.
  Now that we update the .cpp file when the header is changed, we
  lost the declarations therein if e.g. the function return type got
  changed. That then leads to issues in the signature assistant which
  relies on the DUChain data.
  
  I wonder whether we can find a more reliable way to store this data
  to remove such kind of hacks... Problably we will have to work with
  upstream clang and add FixIts for the signature assistant there
  somehow...

REPOSITORY
  rKDEVELOP KDevelop

BRANCH
  5.0

REVISION DETAIL
  https://phabricator.kde.org/D1140

AFFECTED FILES
  languages/clang/codegen/adaptsignatureaction.cpp
  languages/clang/codegen/adaptsignatureaction.h
  languages/clang/codegen/adaptsignatureassistant.cpp
  languages/clang/duchain/builder.cpp
  languages/clang/tests/test_assistants.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mwolff, KDevelop
Cc: kdevelop-devel


More information about the KDevelop-devel mailing list