Review Request 127293: Fix hunk body divider pattern for normal diffs

Kevin Funk kfunk at kde.org
Sun Mar 6 09:27:43 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127293/#review93221
-----------------------------------------------------------


Ship it!




LGTM, but please wait for another +1 from e.g. Jeremy.

- Kevin Funk


On March 6, 2016, 9:27 a.m., Vladimir Panteleev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127293/
> -----------------------------------------------------------
> 
> (Updated March 6, 2016, 9:27 a.m.)
> 
> 
> Review request for KDevelop and Kevin Kofler.
> 
> 
> Repository: libkomparediff2
> 
> 
> Description
> -------
> 
> Commits:
> tests: Verify that the diffs are not malformed
> tests: Add test for normal diffs
> ParserBase: Fix hunk body divider pattern for normal diffs
> 
> 
> Diffs
> -----
> 
>   parserbase.cpp bf919aa9bd2eb388f2d25aa6d99bfa81da7e82b9 
>   tests/interactivedifftest.h d226c139a454e41f0035490042d39a628f9bf906 
>   tests/interactivedifftest.cpp 39acfd8f0db0438ee8180f118f963ce0cc5e4ad9 
> 
> Diff: https://git.reviewboard.kde.org/r/127293/diff/
> 
> 
> Testing
> -------
> 
> Test added and passing.
> 
> 
> Thanks,
> 
> Vladimir Panteleev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160306/bbbc9858/attachment-0001.html>


More information about the KDevelop-devel mailing list