[Development] Are we free of code that checks this isn't null?

[Aleix Pol]

On Fri, Mar 4, 2016 at 10:51 AM, Kevin Funk <kfunk at kde.org> wrote:
> Are *we* free of it?
>
> Simply using this under Clang should tell us about all occurrences:
>   -Werror=undefined-bool-conversion
>
> /me checks
>
> Cheers,
> Kevin
>
> ----------  Forwarded Message  ----------
>
> Subject: [Development] Are we free of code that checks this isn't null?
> Date: Thursday, March 03, 2016, 10:52:15 PM
> From: Thiago Macieira <thiago.macieira at intel.com>
> To: development at qt-project.org
>
> Found in GCC 6's changelog (http://gcc.gnu.org/gcc-6/changes.html):
>
>> Value range propagation now assumes that the this pointer of C++ member
>> functions is non-null. This eliminates common null pointer checks but also
>> breaks some non-conforming code-bases (such as Qt-5, Chromium, KDevelop).
>> As a temporary work-around -fno-delete-null-pointer-checks can be used.
>> Wrong code can be identified by using -fsanitize=undefined.
>
> Are we free of such mistakes? Or do we need to enable -fno-delete-null-
> pointer-checks?

To be honest, I'm not sure what they mean there. Let's enable the
warning for clang and keep an eye on it, no?

Aleix