[Differential] [Commented On] D1047: Parse C files in C mode

[kfunk (Kevin Funk)]

kfunk added a comment.


  Generally: Please rename "CPP" -> "Cpp" in variable names, etc.

INLINE COMMENTS
  languages/plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp:136 `lt` -> `type` or `languageType`
  languages/plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp:154 Code duplication, factor out functionality?
  languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp:85 Initialize in ctor?
  languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.h:73 CPP -> Cpp
  languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp:292 I've seen this code snippet before :)
  
  Please share code

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D1047

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: skalinichev
Cc: kfunk, kdevelop-devel, KDevelop, arrowdodger