Review Request 127241: Change default CTRL+Click jump to definition instead of declaration

Kevin Funk kfunk at kde.org
Tue Mar 1 16:18:03 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127241/#review93020
-----------------------------------------------------------



Thanks for the patch!

Note: This fixes https://bugs.kde.org/show_bug.cgi?id=317876

Append this to the commit message before pushing:

```
BUG: 317876
FIXED-IN: 5.0.0
```

- Kevin Funk


On March 1, 2016, 4:01 p.m., Pedro Ferreira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127241/
> -----------------------------------------------------------
> 
> (Updated March 1, 2016, 4:01 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> The current default behaviour on CTRL+Click causes the editor do jump to the function's declaration. This patch changes that to jump to definition instead.
> I initially wrote this as a personal hack, but from IRC conversations, it seems that I'm not the only one who's annoyed at this behaviour, so here's my upstream attempt.
> Do note that I know little of the sorrounding code. If you believe further changes are required, I'll need some guidance on that.
> 
> 
> Diffs
> -----
> 
>   plugins/contextbrowser/browsemanager.h f631189 
>   plugins/contextbrowser/browsemanager.cpp 1c5cc70 
> 
> Diff: https://git.reviewboard.kde.org/r/127241/diff/
> 
> 
> Testing
> -------
> 
> It works on my projects and on my KDevPlatform project.
> 
> 
> Thanks,
> 
> Pedro Ferreira
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160301/19c7b5ce/attachment-0001.html>


More information about the KDevelop-devel mailing list