Review Request 128284: supporting the -iframework and -F header search path options

René J.V. Bertin rjvbertin at
Tue Jun 28 20:37:57 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated June 28, 2016, 10:37 p.m.)

Review request for KDevelop.


new name for `hasIncludesOrDefines(ProjectBaseItem*)`

Repository: kdevplatform


This is the KDevPlatform companion patch to the work-in-progress under review for KDevelop (

I have stuck with the approach used throughout this class, i.e. keep it abstract. I'd have provided a default implementation returning an empty list myself for this new feature. That would also allow to commit this patch while the other patch is in progress.

I'm a little bit uncomfortable with the mixed use of `frameworkPaths` (requested by Milian in the other RR) and `frameworkDirectories`. The latter is preferable here for reasons that seem obvious to me.

Diffs (updated)

  project/interfaces/ibuildsystemmanager.h ee10c2f 



Builds and works on OS X and Linux provided the other patch is applied.


René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list