[Differential] [Commented On] D1985: Improve gdb plugin unit tests

[qi437103 (Aetf)]

qi437103 added inline comments.

INLINE COMMENTS

> apol wrote in unittest.cpp:35
> That's plenty of specific code without little reason. Try to keep unit tests autocontained and leverage QtTest

Could you elaborate more on this? Did you mean findExecutable and findSourceFile (which might be possible to be replaced by QFINDTESTDATA), or the whole attempt moving debugees to common?

AFAIK, other functions (checking attach, comparing model data and session state waiting) are good candidates to be shared between lldb and gdb plugin.

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D1985

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: qi437103, apol, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160628/73ec9492/attachment.html>