Review Request 128284: supporting the -iframework and -F header search path options

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128284/#review96882
-----------------------------------------------------------


Ship it!




Please push this once the other one is accepted. Then, after you pushed this one, wait for the CI to finish compiling KDevPlatform, then push your other changeset to KDevelop.

Using `Directories` as suffix is OK to me.

- Milian Wolff


On June 25, 2016, 10:17 a.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128284/
> -----------------------------------------------------------
> 
> (Updated June 25, 2016, 10:17 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This is the KDevPlatform companion patch to the work-in-progress under review for KDevelop (https://git.reviewboard.kde.org/r/128272/)
> 
> I have stuck with the approach used throughout this class, i.e. keep it abstract. I'd have provided a default implementation returning an empty list myself for this new feature. That would also allow to commit this patch while the other patch is in progress.
> 
> I'm a little bit uncomfortable with the mixed use of `frameworkPaths` (requested by Milian in the other RR) and `frameworkDirectories`. The latter is preferable here for reasons that seem obvious to me.
> 
> 
> Diffs
> -----
> 
>   project/interfaces/ibuildsystemmanager.h ee10c2f 
> 
> Diff: https://git.reviewboard.kde.org/r/128284/diff/
> 
> 
> Testing
> -------
> 
> Builds and works on OS X and Linux provided the other patch is applied.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160627/10195ba9/attachment.html>