[Differential] [Commented On] D1985: Improve gdb plugin unit tests

apol (Aleix Pol Gonzalez) noreply at phabricator.kde.org
Fri Jun 24 19:13:38 UTC 2016


apol added inline comments.

INLINE COMMENTS

> unittest.cpp:35
> +
> +QUrl findExecutable(const QString& name)
> +{

That's plenty of specific code without little reason. Try to keep unit tests autocontained and leverage QtTest

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D1985

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: qi437103, apol, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160624/9fb8c3a8/attachment.html>


More information about the KDevelop-devel mailing list