Review Request 128201: Improved StatusbarProgressDidget that looks better on OS X and Linux

René J.V. Bertin rjvbertin at
Thu Jun 23 18:32:37 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated June 23, 2016, 8:32 p.m.)

Review request for KDevelop and David Faure.


No more magic numbers.

Repository: kdevplatform


I came across this old bit of code, judging from the use of the deprecated `Q_OS_MAC` token. 
Some quick testing suggests that using `WA_LayoutUsesWidgetRect` achieves what I think is the intended effect without platform-specific code. (That platform test ought really check for using the `macintosh` widget style btw, rather than "are we running on OS X").

Diffs (updated)

  shell/progresswidget/statusbarprogresswidget.cpp 1a32ea8 



For now only on OS X, with the native theme as well as QtCurve, Breeze and Oxygen.

File Attachments

OS X/Mac native *without* the patch
stock widget under Linux (same layout using Breeze)
OS X/native with the new patch
OS X using QtCurve with the new patch
Linux, Breeze, new patch
Linux, QtCurve, new patch
Linux, Oxygen, new patch
Linux, Breeze + Breeze icons, new patch
Linux, QtCurve + Breeze icons, new patch
Linux,Oxygen+Breeze icons, new patch
Linux, Breeze, new patch with maximumHeight from progressBar->sizeHint().height()
X11, Breeze style + icons
X11, Oxygen style, Breeze icons
X11, QtCurve style, Breeze icons
X11, Oxygen style & icons
X11, Oxygen style & icons, expanded state
X11, Breeze, no "additional adjustments"
X11, Oxygen, taller progbar due to "no additional adjustments"


René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list