Review Request 128272: support -iframework and -F header search path options

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128272/#review96800
-----------------------------------------------------------



ok, but you are still missing the defines/includes manager changes as well as forwarding the required stuff from the project manager interfaces


projectmanagers/custommake/makefileresolver/makefileresolver.h (line 43)
<https://git.reviewboard.kde.org/r/128272/#comment65384>

    with explicit...?



projectmanagers/custommake/makefileresolver/makefileresolver.h (line 45)
<https://git.reviewboard.kde.org/r/128272/#comment65383>

    rename to frameworks?



projectmanagers/custommake/makefileresolver/makefileresolver.cpp (line 69)
<https://git.reviewboard.kde.org/r/128272/#comment65382>

    rename to frameworks?



projectmanagers/custommake/makefileresolver/makefileresolver.cpp (line 702)
<https://git.reviewboard.kde.org/r/128272/#comment65381>

    are you sure that these paths cannot be quoted? are you sure they cannot be relative?
    
    I find it odd that you special case this. I'd expect that you'd simply do the quotation and relative path handling and finally do something like
    
        const auto& internedPath = internPath(path);
        const auto& type = match.captured(0);
        const auto isFramework = type.startsWith(QLatin1String("-iframework"))
            || type.startsWith(QLatin1String("-F"));
        if (isFramework) {
            ret.frameworks << internedPath;
        } else {
            ret.paths << internedPath;
        }



projectmanagers/custommake/makefileresolver/makefileresolver.cpp (line 708)
<https://git.reviewboard.kde.org/r/128272/#comment65380>

    broken indentation


- Milian Wolff


On June 22, 2016, 6:50 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128272/
> -----------------------------------------------------------
> 
> (Updated June 22, 2016, 6:50 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This is a draft implementation for parser support of the `-iframework dir` and `-F dir` compiler arguments. On OS X these are the framework equivalents of `-isystem` and `-I` respectively, telling the compiler and/or linker where to find framework bundles.
> 
> I started out making the new code available on OS X only but that introduces a lot of #ifdefs for probably little benefit. On the contrary, clang supports the arguments on Linux too, presumably because clang is a functional cross-compiler that can generate Darwin Mach-O object files on Linux too.
> 
> For the 1st approach I propose to parse the framework directories, adding the effective header directories of the individual frameworks as if they were added explicitly. The framework directories are also added to a new list in the result structure. I presume that this is a prerequisite for adding them to the (lib)clang arguments of the clang parser.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/custommake/makefileresolver/makefileresolver.h 22f9dba 
>   projectmanagers/custommake/makefileresolver/makefileresolver.cpp ab069bb 
>   projectmanagers/custommake/makefileresolver/tests/test_custommake.h 3ad0f36 
>   projectmanagers/custommake/makefileresolver/tests/test_custommake.cpp 368e83e 
> 
> Diff: https://git.reviewboard.kde.org/r/128272/diff/
> 
> 
> Testing
> -------
> 
> the unittest works as expected on OS X.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160622/774836b9/attachment-0001.html>