[Differential] [Updated] D1975: Prepare for lldb plugin: move code from gdb debugger plugin to common one.

[apol (Aleix Pol Gonzalez)]

apol added a comment.


  I'm a bit afraid you might be trying to abstract things out a bit too much. it's ok if GDB and LLDB have some similar code...

INLINE COMMENTS

> midebuggerplugin.cpp:74
> +    // TODO: port tool views
> +    /*
> +    disassemblefactory = new DebuggerToolFactory<DisassembleWidget>(

What's with the commented code?

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D1975

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: qi437103, #kdevelop, apol
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160622/4113f167/attachment.html>