Review Request 128268: GDB plugin enhancements and command queue optimizations

[Peifeng Yu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128268/#review96785
-----------------------------------------------------------



Looks good. FYI, in the refactor I'm doing, command & command queue are moved to `debuggers/common` with some small changes. And code in `gdb.cpp` gets moved to `debuggers/common/midebugger.cpp`.

- Peifeng Yu


On June 21, 2016, 11:34 a.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128268/
> -----------------------------------------------------------
> 
> (Updated June 21, 2016, 11:34 a.m.)
> 
> 
> Review request for KDevelop and Andreas Roth.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This is https://git.reviewboard.kde.org/r/123900 rebased on top of 5.0.
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/debugsession.cpp e1bfed4 
>   debuggers/gdb/disassemblewidget.h d19042d 
>   debuggers/gdb/disassemblewidget.cpp 730aa98 
>   debuggers/gdb/gdb.cpp 38b1ba6 
>   debuggers/gdb/gdbcommand.h 692c0ac 
>   debuggers/gdb/gdbcommand.cpp 3207fdc 
>   debuggers/gdb/gdbcommandqueue.h 9525301 
>   debuggers/gdb/gdbcommandqueue.cpp 4bf11d0 
>   debuggers/gdb/memviewdlg.cpp 7153cd8 
> 
> Diff: https://git.reviewboard.kde.org/r/128268/diff/
> 
> 
> Testing
> -------
> 
> Compilation only.
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160621/10289de0/attachment.html>