[Differential] [Accepted] D1918: Prepare for LLDB DebugSession: Let MIDebugSession handle MICommand instantiation

apol (Aleix Pol Gonzalez) noreply at phabricator.kde.org
Mon Jun 20 15:05:48 UTC 2016


apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  I like it, the API looks cleaner as well.
  
  I assume tests still pass. Go for it, merge to master.

INLINE COMMENTS

> mibreakpointcontroller.cpp:407
> +        debugSession()->addCommand(BreakCondition,
> +                                   QString("%0 %1").arg(breakpoint->debuggerId)
> +                                                   .arg(modelBreakpoint->condition()),

QStringLiteral

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D1918

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: qi437103, apol
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160620/96a5be4a/attachment.html>


More information about the KDevelop-devel mailing list