Review Request 128012: Check for an existing out-of-source build dir
René J.V. Bertin
rjvbertin at gmail.com
Sun Jun 19 19:58:47 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128012/
-----------------------------------------------------------
(Updated June 19, 2016, 9:58 p.m.)
Review request for KDevelop.
Changes
-------
FWIW, this corrects a a bug: proposedBuildFolder should only be set when its value will be returned
Repository: kdevplatform
Description
-------
When importing a new project, check if it already has a pre-existing out-of-source build directory, and propose that as the build directory in `KDevelop::proposedBuildFolder()`.
This is comparable to proposing to put the build folder alongside an existing `src` directory (but has priority over that rule).
Diffs (updated)
-----
project/helper.cpp 6df9f90
Diff: https://git.reviewboard.kde.org/r/128012/diff/
Testing
-------
Builds and behaves as expected.
Thanks,
René J.V. Bertin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160619/85a54e92/attachment.html>
More information about the KDevelop-devel
mailing list