Review Request 128209: restore system environment for subprocesses

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128209/#review96608
-----------------------------------------------------------




util/environmentgrouplist.cpp (line 232)
<https://git.reviewboard.kde.org/r/128209/#comment65279>

    both of these should not be warnings. and they should not be emitted when nothing neds to be changed, no?
    
    also, I'd like to see this become a
    
        static const auto shouldChange = ...;


- Milian Wolff


On June 16, 2016, 7:50 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128209/
> -----------------------------------------------------------
> 
> (Updated June 16, 2016, 7:50 p.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> When running in some kind of container (esp. AppImage), we need to restore the original system environment for all external processes. This patch does that, using the information about the original environment which was set by the startup shell script.
> 
> 
> Diffs
> -----
> 
>   outputview/outputexecutejob.cpp 2f184dc 
>   outputview/outputjob.h 5c9524c 
>   outputview/outputjob.cpp 6a6d1d6 
>   plugins/executescript/scriptappjob.cpp 20d8acd 
>   plugins/externalscript/externalscriptjob.cpp 5b48c2b 
>   util/commandexecutor.cpp 578a6bf 
>   util/environmentgrouplist.h 9e26a1b 
>   util/environmentgrouplist.cpp c762296 
>   vcs/dvcs/dvcsjob.cpp a45d87c 
> 
> Diff: https://git.reviewboard.kde.org/r/128209/diff/
> 
> 
> Testing
> -------
> 
> Can run cmake from KDevelop AppImage now without library errors.
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160616/cfb57fb6/attachment.html>