Review Request 128188: [OS X] Show job progress with Dock icon badge

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128188/
-----------------------------------------------------------

(Updated June 15, 2016, 11:18 p.m.)


Review request for KDE Software on Mac OS X and KDevelop.


Changes
-------

This version links the Dock icon progress bar to the actual QProgressBar in the `StatusbarProgressWidget`, which means it also shows progress from the background parser.

Should I move the `MacDockProgressView` files into the `progresswidget` subdir? They don't seem to belong there as the Dock display isn't part of the progress widget, strictly speaking.


Repository: kdevplatform


Description
-------

This is a follow-up to https://git.reviewboard.kde.org/r/127050/, providing a job progress indication in the Dock (and app switcher), by badging the application icon.

Is it correct that the `RunController` is not used by the (Clang) parser? If so, shouldn't this progress indication (and the Unity one) be moved to the method that updates the progress bar in KDevelop's lower right corner?


Diffs (updated)
-----

  shell/CMakeLists.txt 19a9560 
  shell/macdockprogressview.h PRE-CREATION 
  shell/macdockprogressview.mm PRE-CREATION 
  shell/progresswidget/statusbarprogresswidget.cpp 1a32ea8 

Diff: https://git.reviewboard.kde.org/r/128188/diff/


Testing
-------

Works on OS X 10.9.5 with Qt 5.6.0 and frameworks 5.22.0


File Attachments
----------------

progress badge on a Dock icon
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/e800031a-378b-46fb-88cf-ee55c78d7a1f__Screen_Shot_2016-06-14_at_20.30.55.png
dock icon with progress bar
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/295a93b7-3802-4501-b2dc-3bdf8fa4048b__Screen_Shot_2016-06-15_at_00.02.05.png


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160615/34687663/attachment.html>