Review Request 128201: statusbarprogresswidget::m_pButton: use WA_LayoutUsesWidgetRect instead of setMaximumHeight
René J.V. Bertin
rjvbertin at gmail.com
Wed Jun 15 21:01:57 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128201/
-----------------------------------------------------------
Review request for KDevelop.
Repository: kdevplatform
Description
-------
I came across this old bit of code, judging from the use of the deprecated `Q_OS_MAC` token.
Some quick testing suggests that using `WA_LayoutUsesWidgetRect` achieves what I think is the intended effect without platform-specific code. (That platform test ought really check for using the `macintosh` widget style btw, rather than "are we running on OS X").
Diffs
-----
shell/progresswidget/statusbarprogresswidget.cpp 1a32ea8
Diff: https://git.reviewboard.kde.org/r/128201/diff/
Testing
-------
For now only on OS X, with the native theme as well as QtCurve, Breeze and Oxygen.
Thanks,
René J.V. Bertin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160615/f3c4ad40/attachment.html>
More information about the KDevelop-devel
mailing list