[Differential] [Commented On] D1883: Import CMSYS dependency
arrowdodger (Gleb Popov)
noreply at phabricator.kde.org
Wed Jun 15 08:07:24 UTC 2016
arrowdodger added inline comments.
INLINE COMMENTS
> cmListFileLexer.in.l:508
> #ifdef _WIN32
> - wchar_t* wname = cmsysEncoding_DupToWide(name);
> + wchar_t* wname = kwsysEncoding_DupToWide(name);
> lexer->file = _wfopen(wname, L"rb");
I'd better #define `cmsysEncoding_DupToWide` to `kwsysEncoding_DupToWide` in the `#ifdef Win32` above. This would consolidate our changes to the lexer in one place.
REPOSITORY
rKDEVELOP KDevelop
REVISION DETAIL
https://phabricator.kde.org/D1883
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk
Cc: arrowdodger, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160615/c83126df/attachment.html>
More information about the KDevelop-devel
mailing list