[Differential] [Commented On] D1879: Use KTextEditor::Document::wordAt() instead of custom implementation

dhaumann (Dominik Haumann) noreply at phabricator.kde.org
Tue Jun 14 20:59:34 UTC 2016


dhaumann added inline comments.

INLINE COMMENTS

> brauch wrote in textdocument.cpp:517
> Hmm, the tilde will not be covered by wordAt, will it? This should probably be fixed in the C++ highlighter though, it's wrong here anyways.

Yes, you are correct.

But then, why was the '~' in there in the first place? Can anyone tell?

And there is another difference below: for empty strings, PartDocument::textWord() was returned.

I cannot tell whether this change in behavior will do any bad, since my knowledge of KDevelop mainly lies in KTextEditor :^)

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D1879

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dhaumann, kfunk
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160614/1d634965/attachment.html>


More information about the KDevelop-devel mailing list