[Differential] [Requested Changes To] D1739: Search for binary Qt resource, containing breeze theme. If found, register and use it.

[kfunk (Kevin Funk)]

kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.cpp:385
> +    if (!breezeIcons.isEmpty() && QFile::exists(breezeIcons)) {
> +        QResource::registerResource(breezeIcons, QStringLiteral("/breeze"));
> +        QResource::registerResource(breezeIcons, QStringLiteral("/icons/breeze"));

Why do we need two calls to `QResource::registerResource` with different roots?

I'd prefer if we can do it similar to Kate (a free function inside main.cpp would be enough).
See: https://quickgit.kde.org/?p=kate.git&a=blob&f=icons.h

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D1739

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: arrowdodger, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160601/fdf1feac/attachment.html>