[Differential] [Accepted] D2292: Reapply some patches to 5.0 that are lost when merging into master

kfunk (Kevin Funk) noreply at phabricator.kde.org
Tue Jul 26 19:20:23 UTC 2016


kfunk accepted this revision.
kfunk added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> debugsession.h:78
> +    // Whether turn off auto-disable ASLR when starting inferiors
> +    void setAutoDisableASLR(bool enable);
> +

`//` -> `///` to make it proper doxygen-style comments

Would just remove the first two lines...

> debugsession.h:98
> +
> +    bool m_autoDisableASLR;
>  };

Could initialize with `= false` directly

REPOSITORY
  rKDEVELOP KDevelop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2292

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: qi437103, kfunk
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160726/48db8624/attachment.html>


More information about the KDevelop-devel mailing list