Review Request 127979: Implement color scheme selection from these installed in the system using KColorSchemeManager

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127979/#review97761
-----------------------------------------------------------



+1

Other than that looks good to me. It's a bit workaround-ish how we turned it into an action, but I'd say that the right way to go about it would be to move it to KF5 and implement it properly there.


shell/mainwindow_p.cpp (line 324)
<https://git.reviewboard.kde.org/r/127979/#comment65848>

    Should be `"colorscheme_menu"`. For consistency.


- Aleix Pol Gonzalez


On July 22, 2016, 3:50 p.m., Alexander Zhigalin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127979/
> -----------------------------------------------------------
> 
> (Updated July 22, 2016, 3:50 p.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Bugs: 279592
>     http://bugs.kde.org/show_bug.cgi?id=279592
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Implement color scheme selection from these installed in the system using KColorSchemeManager
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt 336aaaa3b457f3b16350e11e384401c0f8c39f2b 
>   shell/colorschemechooser.h PRE-CREATION 
>   shell/colorschemechooser.cpp PRE-CREATION 
>   shell/mainwindow_p.cpp 70b56db7bed09aeea7a0e57307fb870f65471574 
> 
> Diff: https://git.reviewboard.kde.org/r/127979/diff/
> 
> 
> Testing
> -------
> 
> Manual tensting on Linux, no testing on other systems.
> 
> 
> Thanks,
> 
> Alexander Zhigalin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160722/55f972ad/attachment-0001.html>