Review Request 127979: [WIP] Implement color scheme selection from these installed in the system using KColorSchemeManager

[Aleix Pol Gonzalez]

> On July 12, 2016, 1:31 a.m., Aleix Pol Gonzalez wrote:
> > shell/thememanager.h, line 38
> > <https://git.reviewboard.kde.org/r/127979/diff/2/?file=471193#file471193line38>
> >
> >     Have you considered making this a `QAction`? This would greatly simplify the re-usability of the class.
> 
> Alexander Zhigalin wrote:
>     > This would greatly simplify the re-usability of the class.
>     
>     Explain please

Instead of having a `ThemeManager` that creates a menu, have a:
```
class ThemesAction : public QAction
{};
```

This one internally would initialize its QMenu when necessary.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127979/#review97298
-----------------------------------------------------------


On July 15, 2016, 7:06 p.m., Alexander Zhigalin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127979/
> -----------------------------------------------------------
> 
> (Updated July 15, 2016, 7:06 p.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Bugs: 279592
>     http://bugs.kde.org/show_bug.cgi?id=279592
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> [WIP] Implement color scheme selection from these installed in the system using KColorSchemeManager
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ec521ab8f5dcdd1cc175809f56169259e241ea34 
>   shell/CMakeLists.txt 752c435b81d60e6bf9d438a0367662a8be346a33 
>   shell/mainwindow.h 8340064ee7e1a3b95695b430270cc848ac69eeac 
>   shell/mainwindow.cpp cf1b15d99365a1274f49bbde18bf3c5c17ba7ccb 
>   shell/thememanager.h PRE-CREATION 
>   shell/thememanager.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127979/diff/
> 
> 
> Testing
> -------
> 
> Does compile but doesn't work for some reason.
> 
> 
> Thanks,
> 
> Alexander Zhigalin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160716/9362a6aa/attachment.html>