[Differential] [Request, 33 lines] D2175: Cleanup MIDebugger output signals

[qi437103 (Aetf)]

qi437103 created this revision.
qi437103 added a reviewer: apol.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  There are 4 signals used for various output from the debugger:
  
  - applicationOutput: emitted when got stream record from the 'target' channel
  - userCommandOutput: emitted when got stream record from the 'console' channel and it's a user command
  - internalCommandOutput: emitted when got stream record from the 'console' channel and it's not a user command
  - internalOutput: emitted when got stream record from the 'log' channel or stderr from the debugger
  
  And there are 2 output toolviews when debugging.
  
  - The normal Debug Output panel controled by MIDebugJob
    - Shows applicationOutput, via MIDebugSession::inferiorOutputLines
    - Shows internalCommandOutput, via MIDebugSession::debuggerInternalCommandOutput
  - The GDBOutputWidget which is part of the GDB plugin
    - Shows userCommandOutput, via MIDebugSession::debuggerUserCommandOutput
    - Shows internalCommandOutput, via MIDebugSession::debuggerInternalCommandOutput
    - Shows internalOutput, via MIDebugSession::debuggerInternalOutput
  
  This should match the old behavior for toolviews and fixes the testStdOut unit test.

TEST PLAN
  gdb unit tests

REPOSITORY
  rKDEVELOP KDevelop

BRANCH
  cleanup-dbgoutput-signal

REVISION DETAIL
  https://phabricator.kde.org/D2175

AFFECTED FILES
  debuggers/common/midebugger.cpp
  debuggers/common/midebugger.h
  debuggers/common/midebugjobs.cpp
  debuggers/common/midebugsession.cpp
  debuggers/common/midebugsession.h
  debuggers/gdb/gdboutputwidget.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: qi437103, apol
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160714/7f8b004a/attachment-0001.html>