Review Request 128188: [OS X] Show job progress with Dock icon badge

[René J.V. Bertin]

Hi,

Whatever caused the error below it had a really weird side-effect. The patch to shell/CMakeLists.txt was also applied to the toplevel CMakeLists.txt. I double-checked; that change was *not* part of the patchfile I applied (= the latest from the RR), and I'd stashed all other changes. Either way that spurious change caused an error and I'd rebuilt the whole tree before even considering a local commit.

Any idea what went wrong here? I've never seen `patch` touch files it shouldn't so it must have happened during my local commit ...

R.

> ```
> > git push
> Counting objects: 9, done.
> Delta compression using up to 4 threads.
> Compressing objects: 100% (9/9), done.
> Writing objects: 100% (9/9), 3.10 KiB | 0 bytes/s, done.
> Total 9 (delta 7), reused 0 (delta 0)
> remote: Traceback (most recent call last):
> remote:   File "/home/git/repo-management/hooks/update_review.py", line 160, in <module>
> remote:     main()
> remote:   File "/home/git/repo-management/hooks/update_review.py", line 156, in main
> remote:     close_review(review_id, commit_id, committer, author, ref_change)
> remote:   File "/home/git/repo-management/hooks/update_review.py", line 110, in close_review
> remote:     data=dict(status="submitted", close_description=message))
> remote:   File "/usr/lib/python3/dist-packages/requests/api.py", line 105, in put
> remote:     return request('put', url, data=data, **kwargs)
> remote:   File "/usr/lib/python3/dist-packages/requests/api.py", line 49, in request
> remote:     return session.request(method=method, url=url, **kwargs)
> remote:   File "/usr/lib/python3/dist-packages/requests/sessions.py", line 443, in request
> remote:     prep = self.prepare_request(req)
> remote:   File "/usr/lib/python3/dist-packages/requests/sessions.py", line 374, in prepare_request
> remote:     hooks=merge_hooks(request.hooks, self.hooks),
> remote:   File "/usr/lib/python3/dist-packages/requests/models.py", line 307, in prepare
> remote:     self.prepare_body(data, files, json)
> remote:   File "/usr/lib/python3/dist-packages/requests/models.py", line 452, in prepare_body
> remote:     body = self._encode_params(data)
> remote:   File "/usr/lib/python3/dist-packages/requests/models.py", line 97, in _encode_params
> remote:     v.encode('utf-8') if isinstance(v, str) else v))
> remote: UnicodeEncodeError: 'utf-8' codec can't encode character '\udcc3' in position 69: surrogates not allowed
> remote: This commit is available for viewing at:
> remote: http://commits.kde.org/kdevplatform/c0626300e1c18448dd653a3484fd1ca6298e2d8c
> To ssh://git@git.kde.org/kdevplatform
>    8d0fcb8..c062630  master -> master