[Differential] [Commented On] D2132: Associate MIVariable with MIDebugSession

[apol (Aleix Pol Gonzalez)]

apol added a comment.


  Other than that, LGTM

INLINE COMMENTS

> midebugsession.cpp:123
> +
> +MIVariable* MIDebugSession::findVariableByVarobjName(const QString &varobjName)
> +{

Method should be const

> midebugsession.cpp:127
> +        return nullptr;
> +    return m_allVariables[varobjName];
> +}

To make sure the map isn't modified (although it won't being const) use `m_allvariiables->value(varobjname)`.

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D2132

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: qi437103, #kdevelop, apol
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160711/eebc47fd/attachment.html>