[Differential] [Requested Changes To] D2125: Fix Title Flickering on Document Change

[mwolff (Milian Wolff)]

mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:75
> +if(${KF5_VERSION} VERSION_GREATER "5.23.0")
> +    add_definitions(-DHAS_KF5_GREATER_5_23=1)
> +endif()

please use a config file and configure_file (don't we do that already somewhere?)

also, call it HAS_KF5_24. Furthermore, aren't there version headers for the frameworks which you could include and use in the code directly?

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D2125

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: cordlandwehr, kfunk, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160710/bcca3a2d/attachment-0001.html>