[Differential] [Commented On] D2065: Provide qmake arguments via list.

apol (Aleix Pol Gonzalez) noreply at phabricator.kde.org
Sat Jul 2 16:20:01 UTC 2016


apol added inline comments.

INLINE COMMENTS

> qthelpqtdoc.cpp:64
>          p->setProgram(qmake);
> -        p->setArguments(QStringList(QStringLiteral("-query QT_INSTALL_DOCS")));
> +        p->setArguments(QStringList({QLatin1String("-query"), QLatin1String("QT_INSTALL_DOCS")}));
>          p->start();

Now you're forcing an unnecessary copy constructor ^^'

REPOSITORY
  rKDEVELOP KDevelop

BRANCH
  fixQchFinder

REVISION DETAIL
  https://phabricator.kde.org/D2065

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: cordlandwehr, apol, #kdevelop
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160702/337237be/attachment-0001.html>


More information about the KDevelop-devel mailing list