[Differential] [Accepted] D866: ContextBrowserView: Fix deadlock

mwolff (Milian Wolff) noreply at phabricator.kde.org
Thu Jan 28 15:00:47 UTC 2016


mwolff accepted this revision.
mwolff added a reviewer: mwolff.
mwolff added a comment.
This revision is now accepted and ready to land.


  While this does fix the bug you linked to, I would not close it yet. The problem I describe there is still valid and could easily come back - loading plugins at that point can be very hazardous.
  
  Also, I'd decrease the timeout to ~250ms or similar. 1s is already too much, imo.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

BRANCH
  production

REVISION DETAIL
  https://phabricator.kde.org/D866

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, mwolff
Cc: mwolff, brauch, kdevelop-devel


More information about the KDevelop-devel mailing list