[Differential] [Commented On] D852: [Bug 347351] Display dialog to configure user.name or user.email in git, if commiting without it configured

[kfunk (Kevin Funk)]

kfunk added inline comments.

INLINE COMMENTS
  plugins/git/tests/test_git.cpp:268 This test is too complicated for the test coverage it achieves.
  
  This would basically reach the same coverage:
  * test reading an option which does not exist, assert value empty
  * test setting a option
  * test reading back that option, compare values
  
  Kill `GitInitTest::runTestLocalConfig`, call `{set,read}ConfigOption` directly in here.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D852

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apuzio, kfunk
Cc: mwolff, kdevelop-devel