Review Request 126856: Remove text from documentation find widget's buttons

[Igor Kushnir]

> On Jan. 25, 2016, 2:38 p.m., Aleix Pol Gonzalez wrote:
> > How about getting the actions in the context menu? This grew up quite a bit...

We could add actions to the StandardDocumentationView's context menu manually. In order to preserve the existing standard QWebPage context menu items (such as "Copy" and "Reload"), we could use QWebPage::createStandardContextMenu() and append custom actions to it. This will take some time to implement, so I would like to know if this idea is supported by other reviewers. Which exactly actions should be moved from the top toolbar to the context menu? All except for combobox and line edit?


- Igor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126856/#review91577
-----------------------------------------------------------


On Jan. 23, 2016, 7:46 p.m., Igor Kushnir wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126856/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2016, 7:46 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Remove text from documentation find widget's buttons
> 
> Screenshots: https://drive.google.com/uc?export=download&id=0B0F-aqLyFk_PRWZnS3dLQ3ZHcTQ
> Note that with these changes the top Documentation Tool Bar requires more horizontal space than the documentation find widget. I proposed a solution { split the top toolbar in two rows } in https://git.reviewboard.kde.org/r/126685/ (see links to screenshots in my recent comments).
> 
> 
> Diffs
> -----
> 
>   documentation/documentationfindwidget.cpp 6bf24ab6ecf52d733d13bfae9a459230dab5ca40 
>   documentation/documentationfindwidget.ui ce07311f2c89be70c45bf796a76177c0614cabd4 
> 
> Diff: https://git.reviewboard.kde.org/r/126856/diff/
> 
> 
> Testing
> -------
> 
> Built, installed, tested both with and without documentation zoom implementation.
> 
> 
> Thanks,
> 
> Igor Kushnir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160125/eb893101/attachment-0001.html>