[Differential] [Commented On] D852: [Bug 347351] Display dialog to configure user.name or user.email in git, if commiting without it configured

[kfunk (Kevin Funk)]

kfunk added inline comments.

INLINE COMMENTS
  plugins/git/gitnameemaildialog.cpp:23 No global module includes please. Use `QDialog` and friends
  plugins/git/gitnameemaildialog.cpp:40 I don't get that regexp. This is accepting everything,  right...? Which makes it useless as a validator regex.
  plugins/git/gitnameemaildialog.h:42 Style: Use `const QString& name`, same below and in other places
  plugins/git/gitnameemaildialog.h:49 Typo: `refresh`. Better just call that function `updateUi`
  plugins/git/gitplugin.cpp:434 Style: `{` on same line, same below

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D852

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apuzio, kfunk
Cc: mwolff, kdevelop-devel