Review Request 125664: bug 327760. user will be notified if the debug symbols are missing

[Milian Wolff]

> On Jan. 23, 2016, 6:02 p.m., rishabh  gupta wrote:
> > debuggers/gdb/gdb.h, line 143
> > <https://git.reviewboard.kde.org/r/125664/diff/3/?file=435324#file435324line143>
> >
> >     sorry but didn't get what you meant by "comment then please"

"simplify the code and the comment then please". I.e. just use a boolean, properly named.

    // only display the error message once.
    bool m_reportedMissingSymbolTable = false;

Btw, will this dialog be shown again on consecutive runs (for potentially different targets?


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125664/#review91487
-----------------------------------------------------------


On Jan. 24, 2016, 1:54 p.m., rishabh  gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125664/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2016, 1:54 p.m.)
> 
> 
> Review request for KDevelop, Aleix Pol Gonzalez, Kevin Funk, and Milian Wolff.
> 
> 
> Bugs: 327760
>     http://bugs.kde.org/show_bug.cgi?id=327760
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> code will check if the project compiled is complied with debug symbols or not .if it's not compiled with the debug symbols user will be notified about it
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/gdb.h 087f51e 
>   debuggers/gdb/gdb.cpp 66fee9e 
> 
> Diff: https://git.reviewboard.kde.org/r/125664/diff/
> 
> 
> Testing
> -------
> 
> builds 100%
> testing done
> 
> 
> Thanks,
> 
> rishabh  gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160124/54ccb249/attachment.html>