[Differential] [Commented On] D852: [Bug 347351] Display dialog to configure user.name or user.email in git, if commiting without it configured

[apuzio (Artur Puzio)]

apuzio added inline comments.

INLINE COMMENTS
  plugins/git/gitnameemaildialog.ui:113 In Qt-designer it's not possible to add custom name to a button in button box. (or I wasn't able to find a way)
  plugins/git/tests/test_git.cpp:271 At first I tried to make it data driven, but the initTestCase() and cleanupTestCase() seamed to be interfering with this test. As I don't understand how they are working, I haven't touched them. What I found out is, that repoInit() has to be called at the beginning of the test, because the repo seams to be deleted between tests. If I used data-driven tests the repo would be reinitialized between each test case and that would break my tests.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D852

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apuzio, kfunk
Cc: mwolff, kdevelop-devel