[Differential] [Commented On] D852: [Bug 347351] Display dialog to configure user.name or user.email in git, if commiting without it configured

[mwolff (Milian Wolff)]

mwolff added inline comments.

INLINE COMMENTS
  plugins/git/gitplugin.cpp:427 QStringLiteral
  plugins/git/gitplugin.h:148 add spaces around the = please
  plugins/git/gitplugin.h:149 remove the "get" prefix, just remove it or replace it by "read". these two functions is also what I'd like to see tested. the set of a global option and the getter.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D852

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apuzio, kfunk
Cc: mwolff, kdevelop-devel