[Differential] [Commented On] D852: [Bug 347351] Display dialog to configure user.name or user.email in git, if commiting without it configured

[apuzio (Artur Puzio)]

apuzio added a comment.

@mwolff What do you want my to tests using unit test?
The dialog source (especially after using .ui from Designer) will be very simple. I will only use some abstract functions from other classes. So the potential unit test will in fact be testing the functionality of QRegExpValidator and I don't actually know what else there is to test.
The changes to commit function could be tested (I actually don't know how to test UI interactions, if I don't have the pointer to the QDialog), but again what is there to test? I'm just invoking a getConfigOption, setConfigOption and the QDialog.
What could be tested is the getConfigOption and changes to setConfigOption, but this are also very very simple functions and there isn't any test for the old setConfigOption.


REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D852

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apuzio, kfunk
Cc: mwolff, kdevelop-devel