[Differential] [Commented On] D772: Turn all clang related static libs into a single shared library.

[kfunk (Kevin Funk)]

kfunk added a comment.

Rest LGTM


INLINE COMMENTS
  languages/clang/CMakeLists.txt:32 Lowercase ${target}? See `string(... TOLOWER ...)` in CMake
  languages/clang/CMakeLists.txt:35 And this here should use the plugin version as (SO)VERSION.
  languages/clang/CMakeLists.txt:39 This library should probably go to the normal library install prefix.
  languages/clang/CMakeLists.txt:119 As discussed on IRC, IMO hard-coding RPATH in the installed lib is a no-go. Discouraged by distro packagers.
  
  @mwolff: Agreed? Just using a proper SOVERSION should solve your issue.
  
  Also see: https://wiki.debian.org/RpathIssue
  languages/clang/clangsettings/clangsettingsmanager.h:30 As said above, lowercase + strip kdev prefix for consistency reasons with all the other export headers in kdevplatform/kdevelop.
  
  -> 'clangprivateexport.h'

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D772

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: arrowdodger, KDevelop
Cc: kfunk, mwolff, kdevelop-devel