Review Request 126790: Fix build on openSUSE

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126790/#review91274
-----------------------------------------------------------


Ship it!




Thanks, I submitted this. I changed the version check back to "minor version not larger than 5" though, that was intentionally; python usually changes its API across minor releases and this release most likely will not build with 3.6, so better fail at the configure step.

- Sven Brauch


On Jan. 18, 2016, 4:56 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126790/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 4:56 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> The FindPythonLibs.cmake shipped with CMake does not work there for
> python3 and the necessary variables are already set by our FindPython
> cmake module so we can remove find_package(PythonLibs 3.5.0 REQUIRED)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0972eddf71709a4bf21a27ab0b40227eab9f6dc5 
>   cmake/modules/FindPython.cmake 17d6c30771ee3e9267ba9e737a63158c0b8498c4 
>   parser/CMakeLists.txt 8255a5173ac11c1962f9f454c721a2341edcf9cd 
> 
> Diff: https://git.reviewboard.kde.org/r/126790/diff/
> 
> 
> Testing
> -------
> 
> compiles now
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160118/a7402247/attachment.html>