Review Request 126782: Fix almost all the remaining Clazy warnings in KDevPlatform
Aleix Pol Gonzalez
aleixpol at kde.org
Sun Jan 17 22:28:14 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126782/#review91235
-----------------------------------------------------------
Hey, good work! I found some issues but I understand the warning could have been a bit misleading.
Please take a look at them and fix them.
debugger/breakpoint/breakpointdetails.cpp (line 129)
<https://git.reviewboard.kde.org/r/126782/#comment62267>
->clear()
debugger/breakpoint/breakpointwidget.cpp (line 279)
<https://git.reviewboard.kde.org/r/126782/#comment62268>
QString()
debugger/variable/variablecollection.cpp (line 189)
<https://git.reviewboard.kde.org/r/126782/#comment62269>
QString()
language/codegen/templaterenderer.cpp (line 271)
<https://git.reviewboard.kde.org/r/126782/#comment62270>
QLatin1Char('_')
language/codegen/templatesmodel.cpp (line 183)
<https://git.reviewboard.kde.org/r/126782/#comment62271>
QLatin1Char('/')
language/codegen/templatesmodel.cpp (line 187)
<https://git.reviewboard.kde.org/r/126782/#comment62272>
QLatin1Char('/')
language/codegen/templatesmodel.cpp (line 190)
<https://git.reviewboard.kde.org/r/126782/#comment62273>
QLatin1Char('/')
language/duchain/navigation/abstractdeclarationnavigationcontext.cpp (line 268)
<https://git.reviewboard.kde.org/r/126782/#comment62274>
QLatin1Char(' ')
language/duchain/navigation/abstractdeclarationnavigationcontext.cpp (line 291)
<https://git.reviewboard.kde.org/r/126782/#comment62275>
QLatin1Char('\n')
language/duchain/navigation/abstractdeclarationnavigationcontext.cpp (line 548)
<https://git.reviewboard.kde.org/r/126782/#comment62276>
QLatin1Char(' ')
language/duchain/navigation/abstractdeclarationnavigationcontext.cpp (line 660)
<https://git.reviewboard.kde.org/r/126782/#comment62277>
QString()
language/duchain/tests/test_duchain.cpp (line 245)
<https://git.reviewboard.kde.org/r/126782/#comment62278>
Just remove the initialization.
language/duchain/tests/test_duchain.cpp (line 254)
<https://git.reviewboard.kde.org/r/126782/#comment62279>
bis
language/duchain/tests/test_duchain.cpp (line 316)
<https://git.reviewboard.kde.org/r/126782/#comment62280>
bis
language/duchain/tests/test_duchain.cpp (line 325)
<https://git.reviewboard.kde.org/r/126782/#comment62281>
bis
plugins/appwizard/projectselectionpage.cpp (line 152)
<https://git.reviewboard.kde.org/r/126782/#comment62282>
QString()
plugins/appwizard/projectvcspage.cpp (line 109)
<https://git.reviewboard.kde.org/r/126782/#comment62283>
This code is rather odd... there's 2 returns... :/
Anyway, QString() for now, a FIXME comment wouldn't hurt.
plugins/contextbrowser/browsemanager.h (line 65)
<https://git.reviewboard.kde.org/r/126782/#comment62284>
Why did you move that?
plugins/cvs/checkoutdialog.cpp (line 42)
<https://git.reviewboard.kde.org/r/126782/#comment62285>
QString()
plugins/cvs/cvsjob.cpp (line 48)
<https://git.reviewboard.kde.org/r/126782/#comment62286>
QLatin1Char(' ')
plugins/cvs/cvsplugin.cpp (line 369)
<https://git.reviewboard.kde.org/r/126782/#comment62287>
QString()
plugins/cvs/cvsplugin.cpp (line 466)
<https://git.reviewboard.kde.org/r/126782/#comment62288>
QString()
plugins/cvs/cvsproxy.h (line 68)
<https://git.reviewboard.kde.org/r/126782/#comment62289>
QStrign()
plugins/cvs/cvsproxy.h (line 85)
<https://git.reviewboard.kde.org/r/126782/#comment62290>
bis, and next line. QLatin1String is no good.
plugins/cvs/cvsproxy.cpp (line 144)
<https://git.reviewboard.kde.org/r/126782/#comment62291>
QLatin1Char('.')
plugins/cvs/cvsproxy.cpp (line 149)
<https://git.reviewboard.kde.org/r/126782/#comment62292>
QLatin1Char('.')
plugins/executescript/executescriptplugin.cpp (line 170)
<https://git.reviewboard.kde.org/r/126782/#comment62293>
return QString()
plugins/executescript/scriptappconfig.cpp (line 82)
<https://git.reviewboard.kde.org/r/126782/#comment62294>
QString()
plugins/externalscript/externalscriptjob.cpp (line 367)
<https://git.reviewboard.kde.org/r/126782/#comment62295>
QLatin1Char(' ')
plugins/filetemplates/classmemberspage.cpp (line 69)
<https://git.reviewboard.kde.org/r/126782/#comment62296>
QLatin1Char(' ')
plugins/git/gitplugin.cpp (line 122)
<https://git.reviewboard.kde.org/r/126782/#comment62297>
QString(), on the 3
plugins/grepview/grepoutputmodel.cpp (line 372)
<https://git.reviewboard.kde.org/r/126782/#comment62298>
QString() on both
plugins/grepview/tests/test_findreplace.cpp (line 171)
<https://git.reviewboard.kde.org/r/126782/#comment62299>
QString()
plugins/openwith/openwithplugin.cpp (line 257)
<https://git.reviewboard.kde.org/r/126782/#comment62300>
.clear()
plugins/patchreview/patchreviewtoolview.cpp (line 373)
<https://git.reviewboard.kde.org/r/126782/#comment62301>
QString()
plugins/problemreporter/problemtreeview.cpp (line 371)
<https://git.reviewboard.kde.org/r/126782/#comment62302>
QLatin1Char('\'')
plugins/projectmanagerview/projectmodelsaver.cpp (line 69)
<https://git.reviewboard.kde.org/r/126782/#comment62303>
QLatin1Char('/')
plugins/quickopen/quickopenplugin.cpp (line 1503)
<https://git.reviewboard.kde.org/r/126782/#comment62304>
QString() on both
plugins/subversion/svndiffjob.cpp (line 78)
<https://git.reviewboard.kde.org/r/126782/#comment62305>
'\n'
project/projectmodel.cpp (line 1009)
<https://git.reviewboard.kde.org/r/126782/#comment62306>
QString()
util/environmentgrouplist.cpp (line 218)
<https://git.reviewboard.kde.org/r/126782/#comment62307>
QString()
util/environmentgrouplist.cpp (line 221)
<https://git.reviewboard.kde.org/r/126782/#comment62308>
QLatin1Char('$')
util/kdevstringhandler.cpp (line 98)
<https://git.reviewboard.kde.org/r/126782/#comment62309>
.clear()
- Aleix Pol Gonzalez
On Jan. 17, 2016, 10:44 p.m., Sergey Popov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126782/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2016, 10:44 p.m.)
>
>
> Review request for KDevelop and Aleix Pol Gonzalez.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> I fixed almost all the remaining warnings in KDevPlatform but there are some warnings, which are still not fixed. "Missing Q_OBJECT macro" in some files, generated while building, for example.
>
> Related GCI-2015 task: [https://codein.withgoogle.com/tasks/5200084669038592/](https://codein.withgoogle.com/tasks/5200084669038592/)
>
>
> Diffs
> -----
>
> debugger/breakpoint/breakpointdetails.cpp 1f5a564
> debugger/breakpoint/breakpointwidget.cpp 30a7a4c
> debugger/util/treeitem.cpp c58798f
> debugger/variable/variablecollection.h 2520944
> debugger/variable/variablecollection.cpp 2ade907
> debugger/variable/variabletooltip.cpp ce95f46
> interfaces/contextmenuextension.cpp 191e183
> interfaces/ipartcontroller.cpp 5948371
> interfaces/iplugin.cpp 76da996
> interfaces/isourceformatter.cpp 7a295ca
> language/assistant/renameaction.cpp 8d1c383
> language/assistant/renameassistant.cpp 62f58a0
> language/backgroundparser/backgroundparser.cpp affd601
> language/backgroundparser/documentchangetracker.cpp cbb6359
> language/backgroundparser/parsejob.cpp b38ae36
> language/backgroundparser/parseprojectjob.cpp 1417ac4
> language/backgroundparser/tests/test_backgroundparser.cpp e91182c
> language/backgroundparser/tests/testlanguagesupport.cpp 8b8109b
> language/classmodel/classmodel.cpp 74e4f02
> language/classmodel/classmodelnode.cpp 9d7faab
> language/classmodel/documentclassesfolder.cpp 0d8750c
> language/classmodel/projectfolder.cpp 613529a
> language/codecompletion/codecompletion.cpp c90da5c
> language/codecompletion/codecompletionhelper.cpp f43b25e
> language/codecompletion/codecompletionmodel.cpp aa9c242
> language/codecompletion/normaldeclarationcompletionitem.cpp 09f5342
> language/codegen/applychangeswidget.cpp 6fa12f9
> language/codegen/basicrefactoring.h 9017da5
> language/codegen/basicrefactoring.cpp 57f1b96
> language/codegen/codedescription.cpp 68a5f39
> language/codegen/codedescriptionmetatypes.h ff4bfe4
> language/codegen/coderepresentation.cpp 9652717
> language/codegen/documentchangeset.cpp 1c38a1c
> language/codegen/sourcefiletemplate.cpp 1707d55
> language/codegen/templateclassgenerator.cpp 85dbf36
> language/codegen/templateengine.cpp 1a7adc0
> language/codegen/templaterenderer.cpp 8a6e7ac
> language/codegen/templatesmodel.cpp 125daa9
> language/codegen/tests/test_documentchangeset.cpp baca701
> language/codegen/tests/test_templateclassgenerator.cpp d8136b2
> language/codegen/tests/test_templaterenderer.cpp 86e6288
> language/codegen/tests/test_templatesmodel.cpp 64a01e9
> language/codegen/utilities.h 73033e7
> language/duchain/classdeclaration.cpp ea57238
> language/duchain/declaration.cpp 0d0726f
> language/duchain/declarationid.cpp 206c445
> language/duchain/definitions.cpp 6029d34
> language/duchain/duchain.cpp d0f1e4e
> language/duchain/duchaindumper.cpp 463c1f6
> language/duchain/duchainutils.cpp 7096e05
> language/duchain/ducontext.cpp 0b8fca2
> language/duchain/dumpdotgraph.cpp c3492b4
> language/duchain/functiondefinition.cpp d62f0aa
> language/duchain/identifier.cpp 2e40eb4
> language/duchain/importers.cpp 3c84eff
> language/duchain/instantiationinformation.cpp 1ce3d0b
> language/duchain/navigation/abstractdeclarationnavigationcontext.h 2356416
> language/duchain/navigation/abstractdeclarationnavigationcontext.cpp c2983d8
> language/duchain/navigation/abstractincludenavigationcontext.h ffd84e0
> language/duchain/navigation/abstractincludenavigationcontext.cpp 836d7a7
> language/duchain/navigation/abstractnavigationcontext.cpp 905ac97
> language/duchain/navigation/abstractnavigationwidget.cpp b32ff5b
> language/duchain/navigation/problemnavigationcontext.h ffd71af
> language/duchain/navigation/problemnavigationcontext.cpp fa57987
> language/duchain/navigation/usescollector.cpp 120da9d
> language/duchain/navigation/usesnavigationcontext.h bab42c0
> language/duchain/navigation/usesnavigationcontext.cpp fd0a70a
> language/duchain/navigation/useswidget.cpp 2cb96c2
> language/duchain/parsingenvironment.cpp 4252775
> language/duchain/persistentsymboltable.cpp 21f39bb
> language/duchain/problem.cpp 4c647af
> language/duchain/tests/test_duchain.cpp a3f9721
> language/duchain/tests/test_duchainshutdown.cpp ea090e1
> language/duchain/tests/test_identifier.cpp b5de64c
> language/duchain/topducontext.cpp f3a9a5f
> language/duchain/types/abstracttype.cpp c764fc6
> language/duchain/types/constantintegraltype.cpp 1b75371
> language/duchain/types/functiontype.cpp cfe4044
> language/duchain/types/integraltype.cpp 15fc8a8
> language/duchain/types/pointertype.cpp 1e9fe88
> language/duchain/types/referencetype.cpp 12715ca
> language/duchain/types/structuretype.cpp d6f85f0
> language/duchain/types/typealiastype.cpp d3cc9b8
> language/duchain/types/typerepository.cpp dc81ba3
> language/duchain/types/unsuretype.cpp b3e14bd
> language/duchain/uses.cpp f4a5600
> language/editor/modificationrevisionset.cpp af23f32
> language/highlighting/codehighlighting.cpp d674741
> language/highlighting/colorcache.cpp fa9c7d5
> language/highlighting/configurablecolors.cpp 964eb9f
> language/interfaces/quickopendataprovider.cpp 415574b
> language/interfaces/quickopenfilter.h 0110008
> language/util/setrepository.cpp 14497dc
> outputview/outputdelegate.h 6fedf5f
> outputview/outputexecutejob.cpp 2fd80fd
> outputview/outputfilteringstrategies.cpp 4fdb684
> outputview/tests/test_filteringstrategy.cpp 63409ac
> outputview/tests/test_outputmodel.cpp 7125f05
> outputview/tests/testlinebuilderfunctions.h 40266dc
> plugins/appwizard/appwizardplugin.cpp 87c9a65
> plugins/appwizard/projectselectionpage.cpp 949dd04
> plugins/appwizard/projecttemplatesmodel.h 4bb46d1
> plugins/appwizard/projecttemplatesmodel.cpp d9bb7df
> plugins/appwizard/projectvcspage.cpp d411320
> plugins/bazaar/bazaarplugin.cpp a10a33c
> plugins/bazaar/bazaarutils.cpp edf13aa
> plugins/bazaar/bzrannotatejob.cpp b668563
> plugins/classbrowser/classbrowserplugin.cpp 67d07b3
> plugins/classbrowser/classwidget.cpp a471fa0
> plugins/codeutils/codeutilsplugin.cpp c1e793c
> plugins/contextbrowser/browsemanager.h cbe22bd
> plugins/contextbrowser/browsemanager.cpp c23b428
> plugins/contextbrowser/contextbrowser.cpp 5bc9a6a
> plugins/contextbrowser/contextbrowserview.cpp 57c966f
> plugins/cvs/checkoutdialog.cpp 421f5ad
> plugins/cvs/cvsannotatejob.cpp 8ba726e
> plugins/cvs/cvsdiffjob.cpp 927ba3b
> plugins/cvs/cvsjob.cpp 68f9909
> plugins/cvs/cvsmainview.cpp 4fe0c4f
> plugins/cvs/cvsplugin.cpp 356eb85
> plugins/cvs/cvsproxy.h 7792938
> plugins/cvs/cvsproxy.cpp d6810c4
> plugins/cvs/cvsstatusjob.cpp 11d6e10
> plugins/cvs/editorsview.cpp bb1c6be
> plugins/cvs/importdialog.cpp 23cd9f3
> plugins/documentswitcher/documentswitcherplugin.h 7f7e8af
> plugins/documentswitcher/documentswitcherplugin.cpp 938264a
> plugins/documentswitcher/documentswitchertreeview.h ea349e8
> plugins/documentview/kdevdocumentview.cpp 1fa8156
> plugins/documentview/kdevdocumentviewplugin.cpp abbcbef
> plugins/execute/executeplugin.cpp 770e33e
> plugins/execute/nativeappconfig.cpp a47dff7
> plugins/execute/nativeappjob.cpp 20f97c6
> plugins/execute/projecttargetscombobox.cpp a4d962c
> plugins/executescript/executescriptplugin.cpp d62533e
> plugins/executescript/scriptappconfig.h 9a044fa
> plugins/executescript/scriptappconfig.cpp d4d6c8e
> plugins/executescript/scriptappjob.cpp 7dd2420
> plugins/externalscript/externalscriptjob.cpp 06e4830
> plugins/externalscript/externalscriptplugin.cpp 6838522
> plugins/externalscript/externalscriptview.cpp ee717a6
> plugins/filemanager/kdevfilemanagerplugin.cpp a39f71c
> plugins/filetemplates/classmemberspage.cpp dcd7ca6
> plugins/filetemplates/filetemplatesplugin.cpp 4c734b1
> plugins/filetemplates/licensepage.cpp ddd5829
> plugins/filetemplates/main.cpp 058510f
> plugins/filetemplates/outputpage.cpp aaac553
> plugins/filetemplates/overridespage.cpp 5e39627
> plugins/filetemplates/templateclassassistant.cpp 08309d1
> plugins/filetemplates/templateoptionspage.cpp 2d95f33
> plugins/filetemplates/templatepreview.cpp 705964b
> plugins/filetemplates/templateselectionpage.cpp 70db5e2
> plugins/filetemplates/tests/test_generationtest.cpp 04cb4d6
> plugins/genericprojectmanager/test/test_projectload.cpp 65a4782
> plugins/git/gitjob.h 22fd444
> plugins/git/gitplugin.cpp f06ef4e
> plugins/git/stashmanagerdialog.cpp 308d36c
> plugins/git/tests/test_git.cpp c80a1d3
> plugins/grepview/grepdialog.cpp ee212f1
> plugins/grepview/grepoutputdelegate.h f9a1a64
> plugins/grepview/grepoutputmodel.cpp 47bac97
> plugins/grepview/grepoutputview.cpp cc25669
> plugins/grepview/greputil.cpp 0447a26
> plugins/grepview/grepviewplugin.cpp b59217a
> plugins/grepview/tests/test_findreplace.cpp 3b080d4
> plugins/konsole/kdevkonsoleviewplugin.cpp 6908a7b
> plugins/openwith/openwithplugin.cpp 7603b5a
> plugins/outlineview/outlinenode.cpp 4e722c9
> plugins/outlineview/outlinewidget.cpp 2bc82c4
> plugins/patchreview/localpatchsource.cpp 006aab2
> plugins/patchreview/patchhighlighter.cpp 0d3a757
> plugins/patchreview/patchreview.cpp ef13c0d
> plugins/patchreview/patchreviewtoolview.cpp cbf8320
> plugins/problemreporter/problemhighlighter.cpp 65b3aee
> plugins/problemreporter/problemnavigationcontext.h 5c6a520
> plugins/problemreporter/problemnavigationcontext.cpp db38d42
> plugins/problemreporter/problemreporterplugin.cpp c9ebbb3
> plugins/problemreporter/problemsview.cpp 659ff6d
> plugins/problemreporter/problemtreeview.cpp 59f6166
> plugins/projectfilter/tests/test_projectfilter.cpp 6da4222
> plugins/projectmanagerview/projectbuildsetwidget.cpp 7108a92
> plugins/projectmanagerview/projectmanagerview.cpp 0a8f701
> plugins/projectmanagerview/projectmanagerviewplugin.cpp bdd5dd3
> plugins/projectmanagerview/projectmodelsaver.cpp 3d74426
> plugins/projectmanagerview/projecttreeview.cpp 81ba3ab
> plugins/projectmanagerview/vcsoverlayproxymodel.cpp 4ee9987
> plugins/quickopen/actionsquickopenprovider.h 85d5e9e
> plugins/quickopen/actionsquickopenprovider.cpp ec38c4d
> plugins/quickopen/declarationlistquickopen.h edeab56
> plugins/quickopen/documentationquickopenprovider.h cd96225
> plugins/quickopen/duchainitemquickopen.h 5de72ae
> plugins/quickopen/duchainitemquickopen.cpp f915f6f
> plugins/quickopen/expandingtree/expandingdelegate.cpp 4be0b26
> plugins/quickopen/expandingtree/expandingtree.h 5bd7c97
> plugins/quickopen/expandingtree/expandingwidgetmodel.cpp 34be20b
> plugins/quickopen/projectfilequickopen.cpp d9e14c2
> plugins/quickopen/projectitemquickopen.h fa1a834
> plugins/quickopen/projectitemquickopen.cpp a9a57f5
> plugins/quickopen/quickopenplugin.h 8818d0c
> plugins/quickopen/quickopenplugin.cpp 509623d
> plugins/quickopen/tests/quickopentestbase.cpp 0b0565c
> plugins/quickopen/tests/test_quickopen.cpp 333fbba
> plugins/standardoutputview/outputwidget.cpp 45d65e5
> plugins/standardoutputview/tests/test_standardoutputview.cpp 7522901
> plugins/subversion/kdevsvnplugin.cpp 0287bd7
> plugins/subversion/svnclient.cpp d090551
> plugins/subversion/svncommitjob.cpp b595cd3
> plugins/subversion/svndiffjob.cpp f2e5a53
> plugins/subversion/svninternaljobbase.cpp 5758194
> plugins/subversion/svnjobbase.cpp d3c752c
> plugins/subversion/svnlocationwidget.h 983d2a2
> plugins/subversion/svnssldialog.cpp b654d7c
> plugins/subversion/tests/svnimport.cpp 6fd5c80
> plugins/subversion/tests/svnrecursiveadd.cpp 947f0e6
> plugins/switchtobuddy/switchtobuddyplugin.cpp 3678a45
> plugins/testview/testview.cpp ef8a3ef
> plugins/testview/testviewplugin.cpp 67d200e
> plugins/vcschangesview/vcschangesviewplugin.cpp d55b80a
> plugins/welcomepage/welcomepagedocument.cpp ec7759a
> plugins/welcomepage/welcomepageplugin.cpp 3032f8e
> plugins/welcomepage/welcomepageview.h 4a0f264
> plugins/welcomepage/welcomepageview.cpp 0fbd31d
> project/abstractfilemanagerplugin.cpp feb104a
> project/projectmodel.cpp 17bf418
> project/tests/projectmodelperformancetest.cpp 6adcc83
> project/tests/test_projectmodel.cpp d73f4fd
> serialization/tests/test_indexedstring.cpp 4c424c1
> serialization/tests/test_itemrepository.cpp 4a09417
> shell/assistantpopup.cpp efd8249
> template/filters/kdevfilters.cpp 175726d
> tests/json/delayedoutput.cpp 1483d4f
> tests/json/jsondeclarationtests.h fed47b1
> tests/json/jsonducontexttests.h 11dbbe5
> tests/json/jsontesthelpers.h 564c5a7
> tests/json/jsontypetests.h 6934069
> tests/json/testsuite.h b28708a
> tests/testhelpers.h 1bb7242
> tests/testproject.h 7f37619
> tests/testproject.cpp 4032110
> util/duchainify/main.cpp 452e918
> util/environmentgrouplist.cpp e2e100b
> util/formattinghelpers.h c25bba8
> util/kdevstringhandler.cpp fbb5f64
> util/path.cpp b646fef
> util/shellutils.cpp 34dfead
> util/tests/test_embeddedfreetree.cpp 08e4a40
> util/tests/test_environment.cpp c20200d
> util/tests/test_path.cpp d2a8781
> vcs/dvcs/dvcsjob.cpp fb456bb
> vcs/dvcs/tests/test_dvcsjob.cpp 2b19958
> vcs/models/brancheslistmodel.cpp c78d29a
> vcs/models/tests/test_models.cpp d3f7111
> vcs/vcsrevision.cpp e06abe5
> vcs/widgets/vcsdiffpatchsources.h 8668480
> vcs/widgets/vcsdiffpatchsources.cpp a77bf13
>
> Diff: https://git.reviewboard.kde.org/r/126782/diff/
>
>
> Testing
> -------
>
> Suceessfuly built.
> Tests passed.
>
>
> Thanks,
>
> Sergey Popov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160117/9c3bc5af/attachment-0001.html>
More information about the KDevelop-devel
mailing list