Review Request 125664: bug 327760. user will be notified if the debug symbols are missing

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125664/#review91204
-----------------------------------------------------------




debuggers/gdb/gdb.h (line 140)
<https://git.reviewboard.kde.org/r/125664/#comment62236>

    count of what? add a comment and find a better descriptive name please.
    
    looking at the code, this should be a bool:
    
    bool reportedMissingSymbolTable = false;



debuggers/gdb/gdb.cpp (line 184)
<https://git.reviewboard.kde.org/r/125664/#comment62238>

    add space after ,
    
    and yes, you must add a space after the any or before the breakpoint.
    
    also reprhase:
    
        KMessageBox::error(nullptr, i18n("The executable is missing debug symbols. This severly limits the functionality of the debugger and will prevent it e.g. from stopping at breakpoints set in your source code."), i18n("Debug Symbols Missing"));


- Milian Wolff


On Jan. 14, 2016, 5:35 p.m., rishabh  gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125664/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 5:35 p.m.)
> 
> 
> Review request for KDevelop, Aleix Pol Gonzalez, Kevin Funk, and Milian Wolff.
> 
> 
> Bugs: 327760
>     http://bugs.kde.org/show_bug.cgi?id=327760
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> code will check if the project compiled is complied with debug symbols or not .if it's not compiled with the debug symbols user will be notified about it
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/gdb.h 087f51e 
>   debuggers/gdb/gdb.cpp 66fee9e 
> 
> Diff: https://git.reviewboard.kde.org/r/125664/diff/
> 
> 
> Testing
> -------
> 
> builds 100%
> testing done
> 
> 
> Thanks,
> 
> rishabh  gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160117/787fffdf/attachment-0001.html>