Review Request 126763: Make assistant completion invocation less agressive

Milian Wolff mail at milianw.de
Sun Jan 17 12:20:45 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126763/#review91196
-----------------------------------------------------------



I'm on 5.0 where we reverted all these parts and it's working quite nicely with the floating QQ2 based assistant there. I wonder whether we might end up reverting it in master as well. Maybe it wasn't such a good idea after all. Esp. when you want to solve a fix-it hint, you want to be able to hover the area and see the assistant and apply it. But you don't want the other code completion items to show up...

- Milian Wolff


On Jan. 16, 2016, 1:23 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126763/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2016, 1:23 p.m.)
> 
> 
> Review request for KDevelop, Vavelin Kevin and Olivier de Gaalon.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Currently the completion list opens whenever there's assistants available. That is way too agressive (e.g. when just moving the cursor somewhere, the completion list opens). Also you can barely type a line (or even character) without creating a problem, with an associated clang fixit, which invokes completion. This patch attempts to tackle these problems with two changes:
>  - assistant actions now have a flag telling whether they should be shown automatically. This is only set to "on" for the rename assistant currently. Other assistants are only shown when you invoke completion in some other way (e.g. Ctrl+Space).
>  - problem-associated assistants are only shown when the revision they are associated with matches the current document revision. This avoids showing assistants while the user is typing (e.g. "add semicolon" when the user has in fact already typed the semicolon).
> 
> 
> Diffs
> -----
> 
>   interfaces/iassistant.h 3f93d52 
>   interfaces/iassistant.cpp b606022 
>   language/assistant/assistantcompletionmodel.h 4a6836a 
>   language/assistant/assistantcompletionmodel.cpp 78bd544 
>   language/assistant/renameassistant.cpp 62f58a0 
>   language/assistant/staticassistantsmanager.cpp 92ca321 
> 
> Diff: https://git.reviewboard.kde.org/r/126763/diff/
> 
> 
> Testing
> -------
> 
> Used it for a while. I find kdevelop significiantly more pleasant to use with those changes.
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160117/a5d50652/attachment.html>


More information about the KDevelop-devel mailing list