Review Request 126761: [OS X] handle LaunchServices requests to open files (i.e. from the Finder)

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126761/#review91197
-----------------------------------------------------------




app/main.cpp (line 93)
<https://git.reviewboard.kde.org/r/126761/#comment62233>

    rename to `startHandleFileOpenEvents`.
    
    why can't you do this from the beginning btw? i.e. plain `event` overload instead of an event filter on yourself?



app/main.cpp (line 95)
<https://git.reviewboard.kde.org/r/126761/#comment62232>

    why is this call required? it's usually a really bad idea



app/main.cpp (line 256)
<https://git.reviewboard.kde.org/r/126761/#comment62225>

    remove Q_FUNC_INFO, you can configure qDebug via env vars to output the funciton if you want to see that.



app/main.cpp (line 259)
<https://git.reviewboard.kde.org/r/126761/#comment62227>

    remove the whole conditoinal. you append to the list just before this line, it cannot ever be empty
    
    then remove the fileList altogether and simply pass `openFilesInRunningInstance({{foe->file()}}, pid)` below. Afaik that should work.



app/main.cpp (line 263)
<https://git.reviewboard.kde.org/r/126761/#comment62226>

    remove leading \t



app/main.cpp (line 404)
<https://git.reviewboard.kde.org/r/126761/#comment62230>

    move this block into a free function, make the boolean const. then move it all down to where it is actually being used



app/main.cpp (line 413)
<https://git.reviewboard.kde.org/r/126761/#comment62229>

    `==` instead of `&`? I.e. if shift + controll is pressed, this should not trigger, or?



app/main.cpp (line 503)
<https://git.reviewboard.kde.org/r/126761/#comment62234>

    remove, put it into the commit message



app/main.cpp (line 567)
<https://git.reviewboard.kde.org/r/126761/#comment62231>

    bad replace


- Milian Wolff


On Jan. 15, 2016, 3:50 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126761/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 3:50 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This patch introduces support for file open requests from for instance the Finder, on OS X. It also makes it possible to launch KDevelop from the Finder (or the Dock) with the Command key held, in which case the session picker dialog will be presented if multiple sessions are open.
> 
> 
> Diffs
> -----
> 
>   app/Info.plist.in be256f9 
>   app/main.cpp b5f7bb9 
> 
> Diff: https://git.reviewboard.kde.org/r/126761/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 with Qt 5.5.1 and KF5 Frameworks 5.17.0 installed in /opt/local
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160117/7a61916f/attachment.html>