[Differential] [Commented On] D791: Fix template addition dialog from kdevfiletemplate plugin.

[kfunk (Kevin Funk)]

kfunk added a subscriber: kfunk.
kfunk added a comment.

Looks good to me


INLINE COMMENTS
  plugins/filetemplates/templateselectionpage.cpp:148 `const QStringList filters = {a,b,c};`
  
  
  plugins/filetemplates/templateselectionpage.cpp:151 Nitpick: Remove newline
  plugins/filetemplates/templateselectionpage.cpp:156 Early-return:
  
  ```
  if (!dlg.exec) {
      return;
  }
  
  ...
  ```
  plugins/filetemplates/templateselectionpage.cpp:158 `const&`

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D791

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: arrowdodger, KDevelop
Cc: kfunk, kdevelop-devel