Review Request 126685: Add zoom support for documentation view

[Igor Kushnir]

> On Jan. 11, 2016, 11:37 a.m., Aleix Pol Gonzalez wrote:
> > Wouldn't it be ok just implementing it on a per-view basis using ctrl+mouse wheel?
> 
> Kevin Funk wrote:
>     Note: We have two submissions for fixing this bug.
>     
>     There's also: https://phabricator.kde.org/D774 (with a much less intrusive solution, which I like better)

I added zoom-in and zoom-out buttons because of Kevin's suggestion: https://bugs.kde.org/show_bug.cgi?id=285162#c11
These buttons won't be really useful for everyone's workflow since the mouse wheel is enough. They could improve discover-ability of the feature though.
If the zoom feature would have been implemented on per-view basis, I'm not sure how zoom factor could be synchronized between different views. If it won't be synchronized at all, then this zoom factor should also be stored in KConfig for each view separately. But how to determine a different KConfig entry name in each view? Pass a string as a parameter instead of the DocumentationZoom object? Even then, having to adjust all views' zoom factors separately would be inconvenient for the user. Another solution is a static/global zoomFactor variable. I implemented something similar here: https://bugsfiles.kde.org/attachment.cgi?id=85775 (this is a patch attached to the issue). But I don't really like globals, and I didn't see much of those in the kdevplatform code.

Unfortunately, I can't access https://phabricator.kde.org/D774 to evaluate the alternative implementation, because this particular page seems to be protected and I don't have an account there.


- Igor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126685/#review90878
-----------------------------------------------------------


On Jan. 9, 2016, 6:56 p.m., Igor Kushnir wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126685/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2016, 6:56 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Add zoom support for documentation view
> 
> 
> Diffs
> -----
> 
>   documentation/CMakeLists.txt ff57e258ab5c62ce737c4013005247d585e87b61 
>   documentation/documentationview.h 5f7f6d8bb100ca3f2804cb716a6a4fe98c8ad05e 
>   documentation/documentationview.cpp 9d184a071a49f25ce28f877ffb16c3d2c0b9f1f5 
>   documentation/documentationzoom.h PRE-CREATION 
>   documentation/documentationzoom.cpp PRE-CREATION 
>   documentation/standarddocumentationview.h ba454427165a0df8372fa6d51ebc714423845107 
>   documentation/standarddocumentationview.cpp a9185fd592771f9ead7d4216e08f8c93abab601a 
>   interfaces/idocumentation.h 7673e5fe58ab736d864328b0c8c6b087b197867b 
> 
> Diff: https://git.reviewboard.kde.org/r/126685/diff/
> 
> 
> Testing
> -------
> 
> Built, installed, run tests.
> 
> 
> Thanks,
> 
> Igor Kushnir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160111/3f832260/attachment-0001.html>