[Differential] [Updated] D785: Highlight crashed threadsBUG: 283379

kfunk (Kevin Funk) noreply at phabricator.kde.org
Mon Jan 11 15:35:59 UTC 2016


kfunk added a comment.

Rest LGTM


INLINE COMMENTS
  debugger/framestack/framestackmodel.cpp:151 Please don't hard-code colors.
  
  Use:
  ```
  KColorScheme scheme(QPalette::Active);
  return scheme.foreground(KColorScheme::NegativeText).color();
  ```
  debugger/framestack/framestackmodel.h:88 Symmetry: Also add a getter

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D785

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: itatriev, kfunk
Cc: kdevelop-devel, KDevelop, arrowdodger


More information about the KDevelop-devel mailing list