[Differential] [Updated] D777: [GCI] Use natural sorting in variable list.

kfunk (Kevin Funk) noreply at phabricator.kde.org
Sun Jan 10 19:51:05 UTC 2016


kfunk added a comment.

Looks great, thanks!


INLINE COMMENTS
  debugger/variable/variablesortmodel.cpp:31 Nitpick: Indent this line
  debugger/variable/variablesortmodel.cpp:39 Also here, and everywhere else: No spaces inside `(...)`
  debugger/variable/variablesortmodel.cpp:40 `const`, same below
  debugger/variable/variablesortmodel.h:31 Nitpick: No indent inside namespaces please
  debugger/variable/variablesortmodel.h:36 `nullptr`

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D777

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ematirov, kfunk
Cc: kdevelop-devel, KDevelop, arrowdodger


More information about the KDevelop-devel mailing list