[Differential] [Commented On] D770: Bug 350183 - Support of $VARIABLE in environment settings

[kfunk (Kevin Funk)]

kfunk added inline comments.

INLINE COMMENTS
  util/environmentgrouplist.h:26 `class QProcessEnvironment;` here
  util/environmentgrouplist.h:27 Remove space
  util/environmentgrouplist.h:142 Nitpick: No space after identifier.
  
  Newline before and after.
  util/tests/test_environment.cpp:35 Please avoid overlong lines, hard to read in the diff viewer already.
  
  ```
  ... << ProcEnv{
      {key, value},
      {key, value}
  }
  ```
  util/tests/test_environment.h:1 Nitpick: Use a nicer formatting for the license :)
  
  ```
  /*
   * DESC
   *
   * Copyright NAME
   *
   * This program is free software; you can redistribute it and/or modify
   * it under the terms of the GNU Library General Public License as
   * published by the Free Software Foundation; either version 2 of the
   * License, or (at your option) any later version.
   *
   * This program is distributed in the hope that it will be useful,
   * but WITHOUT ANY WARRANTY; without even the implied warranty of
   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
   * GNU General Public License for more details.
   *
   * You should have received a copy of the GNU General Public
   * License along with this program; if not, write to the
   * Free Software Foundation, Inc.,
   * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
   */
  ```
  util/tests/test_environment.h:22 Newline before

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D770

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apuzio, kfunk
Cc: kdevelop-devel, arrowdodger