[Differential] [Commented On] D769: Remove related actions while removing LaunchConfigurationType.

kfunk (Kevin Funk) noreply at phabricator.kde.org
Sat Jan 9 17:23:36 UTC 2016


kfunk added a comment.

In https://phabricator.kde.org/D769#14605, @kfunk wrote:

> There's `RunController::removeLaunchConfiguration` -- can't we reuse that?
>
> I don't know a lot about that code either, to be fair...


Ah, I think I see. `RunController::removeLaunchConfiguration` also removes things from the config; we probably don't want that when `RunController::removeConfigurationType` was called.

Please introduce a `RunController::removeLaunchConfigurationInternal` (which does *not* touch the config) which is called from `RunController::removeLaunchConfiguration`


REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D769

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ematirov, kfunk
Cc: kdevelop-devel


More information about the KDevelop-devel mailing list