[Differential] [Requested Changes To] D758: Introduce IFilterStrategy::progressInLine [1/3]

[mwolff (Milian Wolff)]

mwolff requested changes to this revision.
mwolff added a reviewer: mwolff.
mwolff added a comment.
This revision now requires changes to proceed.

a few minor things, then it lgtm


INLINE COMMENTS
  outputview/ifilterstrategy.cpp:38 with the above, you can still return {} here then.
  outputview/ifilterstrategy.h:49 int percent = -1;
  
  i.e. default construct it right here.
  outputview/outputfilteringstrategies.cpp:33 keep this template here and use it in this file. that way, we can still have the simple data here in RO memory.
  
  for the outside, feel free to offer a public QVector match function or similar (too bad we don't have array_view yet), and then call this template internally.
  outputview/outputfilteringstrategies.cpp:256 revert this, see above

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D758

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, apol, mwolff
Cc: mwolff, apol, kdevelop-devel, arrowdodger